fix(NavigationManager): Remove break to return all defaultEntryIds #57357
Conversation
Otherwise only the first entry id is returned, breaking loading the value for the "Global Default App" option Signed-off-by: Joda Stößer <[email protected]>
SimJoSt
requested review from
Altahrim,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
|
/backport to stable32 |
|
/backport to stable31 |
|
@SimJoSt please fix the DCO ( |
|
@provokateurin I thought I set it up correctly. |
|
Oh yeah, it was probably that. I set it to manually pass. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Summary
Remove break to return all defaultEntryIds in NavigationManager.
Otherwise, only the first entry id is returned, breaking loading the value for the "Global Default App" option
Before:
After:
Checklist
3. to review, feature component)stable32)